Added changes to enable codeserver on s390x architecture #1627
Conversation
|
Hi @Meghagaur. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @jiridanek , can you please help to review this PR. Thanks! |
| npm install | ||
| npm run build | ||
| VERSION=${CODESERVER_VERSION/v/} npm run build:vscode | ||
| export KEEP_MODULES=1 |
There was a problem hiding this comment.
This copies all the node modules from vscode to codeserver.
https://gitlab.b-data.ch/coder/code-server-builder/-/blob/main/scripts/start.sh?ref_type=heads
| git clone --depth 1 --branch "${CODESERVER_VERSION}" --recurse-submodules --shallow-submodules https://github.com/coder/code-server.git | ||
| cd code-server | ||
|
|
||
| #patch taken from vscodium s390x IBM |
There was a problem hiding this comment.
Url? What problem does it solve?
There was a problem hiding this comment.
here is the url
https://github.com/VSCodium/vscodium/blob/master/patches/linux/reh/s390x/arch-4-s390x-package.json.patch
There was an error for wasm magic number in web-tree-sitter ( a node dependency of vscode ) while building the codeserver rpm.
`# error
[email protected] build:vscode
./ci/build/build-vscode.sh
Updated 1 path from the index
[email protected] gulp
node --max-old-space-size=8192 ./node_modules/gulp/bin/gulp.js vscode-reh-web-linux-s390x-min
[06:58:36] Using gulpfile ~/Test-codeserver/code-server/lib/vscode/gulpfile.js
[06:58:36] Starting 'vscode-reh-web-linux-s390x-min'...
[06:58:36] Starting clean-out-build ...
Unhandled Rejection at: Promise Promise {
Error: need to see wasm magic number
at s (/root/Test-codeserver/code-server/lib/vscode/node_modules/@vscode/l10n-dev/node_modules/web-tree-sitter/tree-sitter.js:1:9928) `
|
Hi @Meghagaur thank you for opening this PR, Could you please apply these changes on the upstream repo first https://github.com/opendatahub-io/notebooks? |
Meghagaur
force-pushed
the
s390x-codeserver-me
branch
from
aaf09fd to
001c4f6
Compare
jiridanek
force-pushed
the
s390x-codeserver-me
branch
from
65abde5 to
a91156b
Compare
|
Hi @Meghagaur some changes have been merged on upstream and they have flow to this repo. Can you rebase your PR and keep the changes only to Dockerfile.konflux files? And maybe clean up the downstream PRs? #1637 |
Meghagaur
force-pushed
the
s390x-codeserver-me
branch
from
a91156b to
9101b77
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @atheo89 I have reopened this pr after rebasing and only added the changes for dockerfile.konflux.cpu |
|
@Meghagaur: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/build-konflux |
1 similar comment
|
/build-konflux |
5 participants
Description
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: